search

clemsonMakerspace / unified-makerspace

The Makerspace - now unified.
Apache License 2.0
9 stars 11 forks source link

Add quiz progress sign-in / bugfix #153

Closed lrboyer closed 6 months ago

lrboyer commented 7 months ago

Goal: Add quiz progress table on sign in page so users can see their quiz progress after successful sign in (Makerspace staff asked for this new feature)

Solution: Add new component to sign in page that will fetch quiz progress and display it.

How: Adds new query parameter on sign in so new component can grab the username

BUGFIX: Local hosting was not working due to "global" not being defined, fixed it in vite.config

ophilli commented 7 months ago

Can you share a screenshot of how this quiz info renders?

ophilli commented 7 months ago

npm run build is failing in the Visitor Frontend Linting step & when I attempt to build it locally.

lrboyer commented 7 months ago

Can you share a screenshot of how this quiz info renders?

![Uploading MakerspaceSigninPrototype.png…]()

ophilli commented 7 months ago

That screenshot link you posted seems to just point to https://github.com/clemsonMakerspace/unified-makerspace/pull/153 and not to a screenshot. Can you try again?

lrboyer commented 7 months ago
MakerspaceSigninPrototype
lrboyer commented 7 months ago

Can you please squash your 4 commits into one single commit?

I think I did that correctly

ophilli commented 6 months ago

Waiting on @plantstevie to review / approve the UX changes.