clemsonMakerspace / unified-makerspace

The Makerspace - now unified.
Apache License 2.0
9 stars 11 forks source link

Fixed; Replaced CRA with Vite and Exposed Build Env Variable for API #85

Closed Mjtlittle closed 2 years ago

Mjtlittle commented 2 years ago

SAME PR AS #79, BUT FIXED THE FRONTEND BUILD

Changes

Deployment

https://d1kquov5x5h6vg.cloudfront.net/

Mjtlittle commented 2 years ago

Sorry @ophilli, I realized I didnt have a PR open for the changes you reverted this morning. I had assumed you just reverted the build; this should be fixed though. I deployed it to my dev environment and its hitting the correct api now (https://d1kquov5x5h6vg.cloudfront.net/).

*ed00930 has the change

ophilli commented 2 years ago

Build artifacts should be up to date & ready to go.

Waiting on scheduling from @Mjtlittle for time to verify deployment. Once you let us know when you can verify I'm happy to merge it.

Mjtlittle commented 2 years ago

Tested this by visiting the site and making both a sign-in and register request (with username 'DELETE ME'). The dynamo table reflected both requests. Also if you make a request and look at the assets it pulls from the cdn, they are the Vite assets and not the CRA ones (different build artifact naming scheme).