search

clenemt / docdash

:zap: Lodash inspired JSDoc 3 template/theme
http://clenemt.github.io/docdash/
Other
824 stars 201 forks source link

Remove jQuery #54

Closed rugk closed 5 years ago

rugk commented 5 years ago

Fixes https://github.com/clenemt/docdash/issues/53

I've only tested it partially in browser, but I may do a full test later.

Also, I really just transferred the jQuery logic 1:1, you can see it is often very suboptimal and could be imroved. Expect a few pushes again.

And I do see it as a big improvment to get rid of this big, big library for just 200 LOC...

rugk commented 5 years ago

And and BTW, I've tested docdash in IE, and I guess we do not have to worry here; the whole site (CSS) is broken there anyway (note this is your unmodified example): grafik

So can we drop IE support?

ar2rsawseen commented 5 years ago

It only means none of the current users use IE. 😃 But since it has been discovered, I think we will need to address that for at least, as you say, IE9

ar2rsawseen commented 5 years ago

Hmm, I just tried and it seems to be working without problems right now

image

rugk commented 5 years ago

Ah, yes, it was this compatibility view. So yeah, we can get back to this PR. 😄

ar2rsawseen commented 5 years ago

So how about this? Save to merge?

rugk commented 5 years ago

If you've tested it, I guess it was. At least theoretically...