search

cleolibrary / CLEO5

CLEO 5 for GTA San Andreas
https://cleo.li
MIT License
57 stars 6 forks source link

release with multiple asi loader versions #119

Closed x87 closed 7 months ago

x87 commented 7 months ago

closes #11

x87 commented 7 months ago

/cc @CanerKaraca23

x87 commented 7 months ago

example build here https://github.com/cleolibrary/CLEO5/releases/tag/v5.0.0-alpha.54

MiranDMC commented 7 months ago

Readme file in both cases mentions ASI Loaded. The "upd1" part in name "SA.CLEO_upd1+Silent_ASI_Loader.zip" will be different, right?

x87 commented 7 months ago

Readme file in both cases mentions ASI Loaded.

what do you mean by "both cases"?

The "upd1" part in name "SA.CLEO_upd1+Silent_ASI_Loader.zip" will be different, right?

it will be the tag name under normal flow

MiranDMC commented 7 months ago

what do you mean by "both cases"?

Inside both release packs. https://github.com/cleolibrary/CLEO5/blob/v5.0.0-alpha.54/README.md?plain=1#L22

MiranDMC commented 7 months ago

It should be 'SA.CLEO_xxx_SDK.zip' instead of SA.CLEO_xxx+SDK.zip

Maybe simple SA.CLEO_xxx.zip instead of SA.CLEO_xxx_no_ASI_Loader.zip

CanerKaraca23 commented 7 months ago

I think the sorting of download section should be like:

And yes, i think "no asi loader" is unnecessary too.

Also i think it will be good adding "vorbisHooked.dll" for Ultimate Asi Loader, but it's optional.

x87 commented 7 months ago

It will be _SDK https://github.com/cleolibrary/CLEO5/pull/119/files#diff-7829468e86c1cc5d5133195b5cb48e1ff6c75e3e9203777f6b2e379d9e4882b3R117

I wanted _no loader so people don't assume this is the default choice. This archive is only for people who already have ASI loader. Otherwise I can imagine tons of questions like: "I downloaded CLEO.zip, why nothing happens when I run the game?"

CanerKaraca23 commented 7 months ago

It will be _SDK https://github.com/cleolibrary/CLEO5/pull/119/files#diff-7829468e86c1cc5d5133195b5cb48e1ff6c75e3e9203777f6b2e379d9e4882b3R117

I wanted _no loader so people don't assume this is the default choice. This archive is only for people who already have ASI loader. Otherwise I can imagine tons of questions like: "I downloaded CLEO.zip, why nothing happens when I run the game?"

Yeah, you're right. Keeping it will be good for regular users. Also adding a huge title to release section like "You need an asi loader to run CLEO" on top of the changelog will be good because many people will not read readme and probably Google will redirect directly to CLEO's GitHub Releases. cleo.li website also need an update with modern look.

Edit: Didn't know cleo.li redirects GitHub, sorry.

x87 commented 7 months ago

cleo.li website also need an update with modern look.

in progress

MiranDMC commented 7 months ago

Maybe there should be no release without ASI loader at all? Is there any reason why UAL should not be default option?

x87 commented 7 months ago

I dunno. I personally never used UAL in San Andreas (mainly because Silent's ASI loader was distributed with CLEO for years). We just give people options and they can choose whatever works for them.

No loader should be present in my opinion for those people who have ASI loader already (not necessarily SAL/UAL), so they just want to unzip the archive and not deal with extra libraries.

x87 commented 7 months ago

Also adding a huge title to release section like "You need an asi loader to run CLEO" on top of the changelog

added an example here, what do you think?

With these instructions I think we can remove _no_loader from the base archive.

CanerKaraca23 commented 7 months ago

Also adding a huge title to release section like "You need an asi loader to run CLEO" on top of the changelog

added an example here, what do you think?

With these instructions I think we can remove _no_loader from the base archive.

Looks good. You can also correct if it's "CLEO5" or "CLEO 5" and the "," on first sentence.

The XXX (upd1) for showing the version?

Also still think SDK should be last.

x87 commented 7 months ago

Also still think SDK should be last.

it will be last when it's generated with _ in the name, not +

asset files are sorted by name

CanerKaraca23 commented 7 months ago

Also still think SDK should be last.

it will be last when it's generated with _ in the name, not +

asset files are sorted by name

I see, thanks.

x87 commented 7 months ago

Updated download instructions again, giving more clarity on each choice.

MiranDMC commented 7 months ago

Also adding a huge title to release section like "You need an asi loader to run CLEO" on top of the changelog

Does not matter how big text you place somewhere, there always will be (great?) percentage of regular users that will ignore it then complain. That's why "default" option should contain some kind of loader, be listed as first entry on list, and look like most basic, not complicated option to go.

x87 commented 7 months ago
CanerKaraca23 commented 7 months ago

README.md should be updated as well as @MiranDMC mentioned since UAL added too.

CanerKaraca23 commented 7 months ago

Also adding a huge title to release section like "You need an asi loader to run CLEO" on top of the changelog

Does not matter how big text you place somewhere, there always will be (great?) percentage of regular users that will ignore it then complain. That's why "default" option should contain some kind of loader, be listed as first entry on list, and look like most basic, not complicated option to go.

Hmm. Removing No ASI Loader option will still cause regular users (ignoring the guide ones) ask about "what is the difference? which to install?, which one is better?" for asi loaders of download options.

Then there is two options, merge this PR, or maintain the status quo with SAL.

CanerKaraca23 commented 7 months ago

I think also adding vorbisHooked.dll to UAL package will help people who want to uninstall asi loader or/and cleo. Also in UAL's GitHub readme.

x87 commented 7 months ago

I think also adding vorbisHooked.dll to UAL package will help people who want to uninstall asi loader or/and cleo. Also in UAL's GitHub readme.

I don't think this is something CLEO should do. If the author of UAL does not provide a backup file, neither should we. You can open a ticket in UAL repo requesting the change.

CanerKaraca23 commented 7 months ago

I think also adding vorbisHooked.dll to UAL package will help people who want to uninstall asi loader or/and cleo. Also in UAL's GitHub readme.

I don't think this is something CLEO should do. If the author of UAL does not provide a backup file, neither should we. You can open a ticket in UAL repo requesting the change.

Screenshot_20240408-191131_Chrome

x87 commented 7 months ago

I think also adding vorbisHooked.dll to UAL package will help people who want to uninstall asi loader or/and cleo. Also in UAL's GitHub readme.

I don't think this is something CLEO should do. If the author of UAL does not provide a backup file, neither should we. You can open a ticket in UAL repo requesting the change.

Screenshot_20240408-191131_Chrome

OK, what does it mean for this PR?

CanerKaraca23 commented 7 months ago

I think also adding vorbisHooked.dll to UAL package will help people who want to uninstall asi loader or/and cleo. Also in UAL's GitHub readme.

I don't think this is something CLEO should do. If the author of UAL does not provide a backup file, neither should we. You can open a ticket in UAL repo requesting the change.

Screenshot_20240408-191131_Chrome

OK, what does it mean for this PR?

Just mentioned as an optional. It's up to you of course.