cleophasmashiri / oppia

Automatically exported from code.google.com/p/oppia
Apache License 2.0
0 stars 0 forks source link

Code review request #676

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Branch name:
number_with_input

Link to the relevant commit(s):

Purpose of code changes on this branch:
Starting off an interaction, just checking on design so far.

When reviewing my code changes, please focus on:
Whether I'm making any early on design missteps. This will be incremental, so 
I'll be adding to this soon enough. Feel free to give any advice as this is my 
first feature in Oppia.

After the review, I'll merge this branch into: develop
But only after a bunch more commits. :)

Original issue reported on code.google.com by maddenw...@gmail.com on 24 Mar 2015 at 9:33

GoogleCodeExporter commented 9 years ago
Hi Zoe!

First, a quick note: in general, please include a link to the relevant commits 
in the review request. For this one it would be:

    https://code.google.com/p/oppia/source/detail?r=75cf863d05b7261e1192817d4852b0ad67847001&name=number_with_input#

With regards to the commit itself, I think this is actually a little too early 
for a reviewer to say anything meaningful, and it would be better to do a bit 
more until you have something basic working (i.e. it should at least display 
something in the frontend, even if it's a placeholder). How about you iterate 
on it a little more? If you have any specific questions in the meantime, 
though, please don't hesitate to ask!

Original comment by s...@seanlip.org on 25 Mar 2015 at 12:26

GoogleCodeExporter commented 9 years ago
(Oh, and please feel free to make a comment to this issue thread when you've 
got something working! This will pop an email into our inboxes.)

Original comment by s...@seanlip.org on 25 Mar 2015 at 12:27

GoogleCodeExporter commented 9 years ago
Sounds good! Seemed a little early, so I'll just wait a bit next time.

Zoe

Original comment by maddenw...@gmail.com on 25 Mar 2015 at 1:11

GoogleCodeExporter commented 9 years ago

Original comment by jacobdav...@gmail.com on 26 Mar 2015 at 9:32