search

cleophasmashiri / oppia

Automatically exported from code.google.com/p/oppia
Apache License 2.0
0 stars 0 forks source link

Code review request #678

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Branch name:
social-media-buttons

Link to the relevant commit(s):
https://code.google.com/p/oppia/source/detail?r=b63b7500ba318cb32e88bfe270c7eb7f
a8b2310f&name=social-media-buttons

Purpose of code changes on this branch:
Add social media chicklets to sidenav

When reviewing my code changes, please focus on:
Code health, UI
Sean-- I sense that because the URLs are specific, the social media buttons 
probably need to be abstracted (so that the Oppia codebase doesn't point to 
oppia.org's social media pages). Is this something you could do?
Mike-- what do you think of the images? If you like them, we should use them 
for the share dropdown menu as well.

Thanks!

After the review, I'll merge this branch into: develop

Original issue reported on code.google.com by amitdeut...@google.com on 26 Mar 2015 at 6:19

GoogleCodeExporter commented 9 years ago 
Code looks excellent, thanks! I'll work on the abstraction -- in the meantime, 
please hold off on the merge.

Original comment by s...@seanlip.org on 26 Mar 2015 at 6:27

GoogleCodeExporter commented 9 years ago 
OK, done!

    https://code.google.com/p/oppia/source/detail?r=22870880d837b191a2520e90c2b65abf563a3e9e&name=social-media-buttons

Will merge to develop.

Original comment by s...@seanlip.org on 27 Mar 2015 at 4:00