cleophasmashiri / oppia

Automatically exported from code.google.com/p/oppia
Apache License 2.0
0 stars 0 forks source link

Code review request #679

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Branch name:
update-start-script

Link to the relevant commit(s):
https://code.google.com/p/oppia/source/detail?r=ea8225d8492e5916a512831d189c37d9
f26312e5&name=update-start-script#

Purpose of code changes on this branch:
Add --no_browser flag to start script, because it's a bit annoying that you 
have to have a new browser window every time you stop and restart the script.

When reviewing my code changes, please focus on:
Code health (did I do this right?) and need (is it okay to add this to the 
start script?)

After the review, I'll merge this branch into: develop

Original issue reported on code.google.com by amitdeut...@google.com on 26 Mar 2015 at 3:35

GoogleCodeExporter commented 9 years ago
+Jacob

Hmm. With regards to need, I don't particularly care for this option, and am 
somewhat against increasing the complexity of the shell scripts. So I would 
lean fairly strongly towards saying no.

But perhaps I'm atypical, and other people would find this useful. Jacob -- do 
you have any thoughts re need?

Original comment by s...@seanlip.org on 26 Mar 2015 at 11:33

GoogleCodeExporter commented 9 years ago
Personally I don't have a need for this.

Original comment by jacobdav...@gmail.com on 26 Mar 2015 at 11:42

GoogleCodeExporter commented 9 years ago
OK, thanks Jacob.

Amit -- going to say no to this change for now, but I'd be happy to revisit if 
this ends up being either a significant inconvenience for one person, or a 
moderate inconvenience for more than one person.

Original comment by s...@seanlip.org on 26 Mar 2015 at 11:44