Open cleowenxuan opened 6 months ago
No details provided by team.
[The team marked this bug as a duplicate of the following bug]
No handling of highly possible duplicate persons
add
n/Amanda Tan p/87654321 t/COVID
was run to first add a person, next,add n/Amanda Tan p/87654321
was run (additional whitespace between words).The outcome was that the second person could be added successfully below without warning or prevention.
There was no clear mention on whether duplication detection was done for names in the UG, and because of this, whenever a user forgets that he had previously added a person already, he might add duplicate entries without realizing sometimes.
After running the
add n/Amanda Tan p/87654321 t/COVID
and seeing the result below,The duplication check is done whereby entries are treated as duplicates likely only if all fields present are equal, I feel that this may be a feature flaw and potentially problematic since a user is not likely to type in exactly same commands multiple times and two entries with same person name or even phone number by itself should indicate a unique identity.
[original: nus-cs2103-AY2324S2/pe-interim#3707] [original labels: severity.Medium type.FeatureFlaw]
[This is the team's response to the above 'original' bug]
It is indeed possible for two people to share the same name (there are at least five Jun Jie’s in NUS at present), and it is also possible for two contacts to have the same phone number (a parent and a child). Hence, checking equality of contacts by checking equality of both name and phone number is an intended behavior and not a bug. We think the duplicate rate resulting from typos such as this is sufficiently negligible that we will not implement anything extra to resolve such “highly possible duplicate persons”.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
Reason for disagreement: [replace this with your explanation]
As mentioned in the textbook, different cases of the same word (eg: "John Doe" and "john Doe") is unlikely to mean different people. The app should at least give a warning to this kind of cases, since it might be a good chance that it is a typo.