clerk / javascript

Official JavaScript repository for Clerk authentication
https://clerk.com
MIT License
1.18k stars 267 forks source link

The German file does not have the correct Typescipt type. #2962

Closed alamenai closed 8 months ago

alamenai commented 8 months ago

Preliminary Checks

Reproduction / Replay Link

https://jam.dev/c/575929e8-55a3-42cc-a07f-27e89d06dd2e

Publishable key

sk_test_9ncXiHqKzBHF4SbbtANcYvE2fTOVMrDuiUn8mnzqp2

Description

  1. Go to custom localization doc
  2. Create a custom localization file named auth-de.ts.
  3. Copy and paste the content of German translation

Then I faced these Typescript issue:

image

image

Environment

System:
    OS: Linux 6.5 Ubuntu 22.04.3 LTS 22.04.3 LTS (Jammy Jellyfish)
    CPU: (8) x64 Intel(R) Core(TM) i5-8265U CPU @ 1.60GHz
    Memory: 2.04 GB / 7.46 GB
    Container: Yes
    Shell: 5.1.16 - /bin/bash
  Binaries:
    Node: 20.11.0 - ~/.nvm/versions/node/v20.11.0/bin/node
    Yarn: 1.22.19 - /snap/bin/yarn
    npm: 10.2.4 - ~/.nvm/versions/node/v20.11.0/bin/npm
    pnpm: 8.11.0 - /usr/local/bin/pnpm
    bun: 1.0.16 - ~/.bun/bin/bun
    Watchman: 20221225.010033.0 - /usr/local/bin/watchman
  Browsers:
    Chrome: 120.0.6099.224
  npmPackages:
    @babel/preset-react: ^7.23.3 => 7.23.3
    @clerk/localizations: ^1.24.1 => 1.26.16
    @clerk/nextjs: ^4.29.9 => 4.29.9
    @clerk/themes: ^1.7.9 => 1.7.9
    @commitlint/cli: ^17.8.1 => 17.8.1
    @commitlint/config-conventional: ^17.8.1 => 17.8.1
    @cypress/code-coverage: ^3.12.19 => 3.12.28
    @headlessui/tailwindcss: ^0.2.0 => 0.2.0
    @hookform/resolvers: ^3.3.4 => 3.3.4
    @istanbuljs/nyc-config-typescript: ^1.0.2 => 1.0.2
    @jest/globals: ^29.7.0 => 29.7.0
    @mapbox/mapbox-gl-geocoder: ^5.0.2 => 5.0.2
    @mapbox/search-js-react: 1.0.0-beta.18 => 1.0.0-beta.18
    @mdx-js/loader: ^3.0.0 => 3.0.1
    @mdx-js/react: ^3.0.0 => 3.0.1
    @next/mdx: ^14.1.0 => 14.1.3
    @radix-ui/react-accordion: ^1.1.2 => 1.1.2
    @radix-ui/react-alert-dialog: ^1.0.5 => 1.0.5
    @radix-ui/react-aspect-ratio: ^1.0.3 => 1.0.3
    @radix-ui/react-checkbox: ^1.0.4 => 1.0.4
    @radix-ui/react-collapsible: ^1.0.3 => 1.0.3
    @radix-ui/react-dialog: ^1.0.5 => 1.0.5
    @radix-ui/react-dropdown-menu: ^2.0.6 => 2.0.6
    @radix-ui/react-hover-card: ^1.0.7 => 1.0.7
    @radix-ui/react-label: ^2.0.2 => 2.0.2
    @radix-ui/react-popover: ^1.0.7 => 1.0.7
    @radix-ui/react-radio-group: ^1.1.3 => 1.1.3
    @radix-ui/react-separator: ^1.0.3 => 1.0.3
    @radix-ui/react-slot: ^1.0.2 => 1.0.2
    @radix-ui/react-switch: ^1.0.3 => 1.0.3
    @radix-ui/react-tabs: ^1.0.4 => 1.0.4
    @radix-ui/react-toast: ^1.1.5 => 1.1.5
    @radix-ui/react-tooltip: ^1.0.7 => 1.0.7
    @reduxjs/toolkit: ^1.9.5 => 1.9.7
    @sentry/nextjs: ^7.80.0 => 7.106.0
    @storybook/addon-essentials: ^7.6.10 => 7.6.17
    @storybook/addon-interactions: ^7.6.10 => 7.6.17
    @storybook/addon-links: ^7.6.10 => 7.6.17
    @storybook/addon-onboarding: ^1.0.11 => 1.0.11
    @storybook/blocks: ^7.6.10 => 7.6.17
    @storybook/nextjs: ^7.6.10 => 7.6.17
    @storybook/react: ^7.6.10 => 7.6.17
    @storybook/testing-library: ^0.2.2 => 0.2.2
    @testing-library/jest-dom: ^6.1.2 => 6.4.2
    @testing-library/react: ^14.1.2 => 14.2.1
    @tremor/react: ^3.11.0 => 3.14.1
    @trivago/prettier-plugin-sort-imports: ^4.3.0 => 4.3.0
    @types/mdx: ^2.0.10 => 2.0.11
    @types/node: 20.4.0 => 20.4.0
    @types/react: ^18.2.48 => 18.2.64
    @types/react-dom: ^18.2.18 => 18.2.21
    @typescript-eslint/eslint-plugin: ^6.19.1 => 6.21.0
    @typescript-eslint/parser: ^6.19.1 => 6.21.0
    autoprefixer: ^10.4.17 => 10.4.18
    babel-plugin-istanbul: ^6.1.1 => 6.1.1
    chai-colors: ^1.0.1 => 1.0.1
    chart.js: ^4.4.1 => 4.4.2
    class-variance-authority: ^0.7.0 => 0.7.0
    classnames: ^2.3.2 => 2.5.1
    clsx: ^2.1.0 => 2.1.0
    cmdk: ^0.2.1 => 0.2.1
    contentlayer: ^0.3.4 => 0.3.4
    cypress: ^13.6.3 => 13.6.6
    cypress-react-selector: ^3.0.0 => 3.0.0
    date-fns: ^3.3.1 => 3.3.1
    eslint: ^8.56.0 => 8.57.0
    eslint-config-next: ^14.1.0 => 14.1.3
    eslint-config-prettier: ^9.1.0 => 9.1.0
    eslint-plugin-cypress: ^2.15.1 => 2.15.1
    eslint-plugin-import: ^2.29.1 => 2.29.1
    eslint-plugin-jsx-a11y: ^6.8.0 => 6.8.0
    eslint-plugin-react: ^7.33.2 => 7.34.0
    eslint-plugin-react-hooks: ^4.6.0 => 4.6.0
    eslint-plugin-simple-import-sort: ^10.0.0 => 10.0.0
    eslint-plugin-storybook: ^0.6.15 => 0.6.15
    fetch-mock: ^9.11.0 => 9.11.0
    framer-motion: ^10.18.0 => 10.18.0
    husky: ^8.0.3 => 8.0.3
    i18next: ^23.4.3 => 23.10.1
    i18next-browser-languagedetector: ^7.1.0 => 7.2.0
    i18next-resources-to-backend: ^1.1.4 => 1.2.0
    istanbul-lib-coverage: ^3.2.0 => 3.2.2
    jest: ^29.7.0 => 29.7.0
    jest-environment-jsdom: ^29.7.0 => 29.7.0
    jest-next-dynamic: ^1.0.1 => 1.0.1
    lint-staged: ^13.3.0 => 13.3.0
    lucide-react: ^0.335.0 => 0.335.0
    mapbox-gl: ^3.0.0 => 3.2.0
    msw: ^1.3.2 => 1.3.2
    next: ^14.1.0 => 14.1.3
    next-contentlayer: ^0.3.4 => 0.3.4
    next-themes: ^0.2.1 => 0.2.1
    node-fetch: ^3.3.2 => 3.3.2
    normalize.css: ^8.0.1 => 8.0.1
    nuqs: ^1.17.0 => 1.17.1
    nyc: ^15.1.0 => 15.1.0
    postcss: ^8.4.33 => 8.4.35
    prettier: ^3.2.4 => 3.2.5
    react: ^18.2.0 => 18.2.0
    react-chartjs-2: ^5.2.0 => 5.2.0
    react-day-picker: ^8.10.0 => 8.10.0
    react-dom: ^18.2.0 => 18.2.0
    react-hook-form: ^7.50.1 => 7.51.0
    react-i18next: ^13.5.0 => 13.5.0
    react-icons: ^4.12.0 => 4.12.0
    react-redux: ^8.1.3 => 8.1.3
    react-to-print: ^2.14.15 => 2.15.1
    redux-persist: ^6.0.0 => 6.0.0
    sharp: ^0.32.3 => 0.32.6
    simplex-noise: ^4.0.1 => 4.0.1
    sonner: ^1.4.2 => 1.4.3
    storybook: ^7.6.10 => 7.6.17
    stylelint: ^15.11.0 => 15.11.0
    stylelint-config-standard: ^34.0.0 => 34.0.0
    stylelint-prettier: ^4.1.0 => 4.1.0
    swr: ^2.2.0 => 2.2.5
    tailwind-merge: ^2.2.1 => 2.2.1
    tailwindcss: ^3.4.1 => 3.4.1
    tailwindcss-animate: ^1.0.7 => 1.0.7
    ts-jest: ^29.1.2 => 29.1.2
    ts-node: ^10.9.2 => 10.9.2
    tsconfig-paths-jest: ^0.0.1 => 0.0.1
    usehooks-ts: ^2.15.1 => 2.16.0
    vaul: ^0.9.0 => 0.9.0
    whatwg-fetch: ^3.6.18 => 3.6.20
    zod: ^3.22.4 => 3.22.4
alamenai commented 8 months ago

The same issue for the EN-US file.

LekoArts commented 8 months ago

Hi!

Sorry to hear you're running into an issue. To help us best begin debugging the underlying cause, it is incredibly helpful if you're able to create a minimal reproduction. This is a simplified example of the issue that makes it clear and obvious what the issue is and how we can begin to debug it.

Can you also provide the output for this command in the terminal?

npm ls @clerk/types

I'm suspecting you're using an incorrect version.

Thanks for using Clerk!

alamenai commented 8 months ago

Hi @LekoArts , thank you for your reply.

I resolved the issue by importing the i18n files from the @clerk/localizations instead of copying/pasting them.

The issue was that the current i18n files ( translations ) are following the deprectaed properties in the clerk/types.