clerk / javascript

Official Javascript repository for Clerk authentication
https://clerk.com
MIT License
981 stars 222 forks source link

Slim down on dependencies #3055

Open mcmxcdev opened 4 months ago

mcmxcdev commented 4 months ago

Preliminary Checks

Reproduction

Publishable key

Description

Looking at the package.json below, Clerk pulls in various dependencies that can probably be dropped nowadays: https://github.com/clerk/javascript/blob/50b4176a1b8acfaff691a10ae55597834c90ce53/packages/clerk-js/package.json#L63-L68

Expected behavior: Project should be kept as slim as possible

Actual behavior: End users of Clerk have to download and install more deps, which can have CVEs and require more disk space and install time.

Environment

System:
    OS: Linux 6.5 Ubuntu 23.10 23.10 (Mantic Minotaur)
    CPU: (16) x64 AMD Ryzen 7 5800H with Radeon Graphics
    Memory: 17.57 GB / 30.71 GB
    Container: Yes
    Shell: 5.9 - /usr/bin/zsh
  Binaries:
    Node: 20.11.0 - ~/.volta/tools/image/node/20.11.0/bin/node
    Yarn: 1.22.22 - ~/.volta/tools/image/yarn/1.22.22/bin/yarn
    npm: 10.2.4 - ~/.volta/tools/image/node/20.11.0/bin/npm
    pnpm: 8.14.1 - ~/.volta/tools/image/pnpm/8.14.1/bin/pnpm
  Browsers:
    Brave Browser: 123.1.64.109
    Chrome: 123.0.6312.58
  npmPackages:
     "clerk-sveltekit": "^0.4.1"c
dimkl commented 4 months ago

Hello @mcmxcdev Thank you for this feedback. Indeed, it seems we can reduce the dependencies, so we will create a ticket and assign the appropriate priority. In the meantime, if you are interested in contributing to ClerkJS we are open for PRs.

Resources:

mcmxcdev commented 4 months ago

I appreciate the openness to my suggestions! I will consider creating some PRs if I can manage to find the time.