clerk / javascript

Official Javascript repository for Clerk authentication
https://clerk.com
MIT License
1.1k stars 243 forks source link

feat(ui): Implement `<SecondaryButton />` component #3533

Closed alexcarpenter closed 4 months ago

alexcarpenter commented 4 months ago

Description

default:

Screenshot 2024-06-06 at 4 28 36 PM

busy:

Screenshot 2024-06-06 at 4 29 03 PM

icon only:

Screenshot 2024-06-06 at 4 29 51 PM

<SecondaryButton icon={<Icon.Google />}>
  <span className='sr-only'>Continue with Github</span>
</SecondaryButton>

Maybe handle this internal with iconOnly prop? Still require the children which would be wrapped in sr-only class.

https://linear.app/clerk/issue/SDKI-27/implement-use-other-methods-buttons

Checklist

Type of change

changeset-bot[bot] commented 4 months ago

🦋 Changeset detected

Latest commit: 2c178e91e27ab9b76dd7ae0e722aced580513565

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR