clerk / javascript

Official Javascript repository for Clerk authentication
https://clerk.com
MIT License
981 stars 221 forks source link

fix(clerk-js): Deprecate `afterSignOutUrl` from UserButton #3544

Closed panteliselef closed 1 month ago

panteliselef commented 1 month ago

Description

Fixes: DASH-183

This PR address the following issues:

The main issue is that we don't propagate afterSignOutUrl and afterMultiSessionSingleSignOutUrl from the UserButton to UserProfile.

This PR addresses that by positioning those props at the root lever (ClerkProvider or Clerk.load). We considered simply introducing those props to UserProfile, but the naming would not be ideal. We also considered renaming them, but at that point you want the components to always be in sync, so we positioned them at the root.

Checklist

Type of change

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 29a930c22bdb8bab731a45f8c90e56ff2a601923

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages | Name | Type | | ----------------------- | ----- | | @clerk/clerk-js | Minor | | @clerk/types | Minor | | @clerk/chrome-extension | Patch | | @clerk/clerk-expo | Patch | | @clerk/backend | Patch | | @clerk/elements | Patch | | @clerk/express | Patch | | @clerk/fastify | Patch | | @clerk/localizations | Patch | | @clerk/nextjs | Patch | | @clerk/clerk-react | Patch | | @clerk/remix | Patch | | @clerk/clerk-sdk-node | Patch | | @clerk/shared | Patch | | @clerk/tanstack-start | Patch | | @clerk/testing | Patch | | @clerk/themes | Patch | | @clerk/ui | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR