fix(ui): Remove data-invalid overrides - Githubissues

clerk / javascript

Official Javascript repository for Clerk authentication

https://clerk.com

MIT License

1.09k stars 241 forks source link

fix(ui): Remove data-invalid overrides #3571

Closed alexcarpenter closed 3 months ago

alexcarpenter commented 3 months ago

Description

Only render input error border and ring when in an error state, not when data-invalid which is trigged when an input is required.

BEFORE:

https://github.com/clerk/javascript/assets/825855/03cac767-cd68-404a-8f18-ead8f73bff60

AFTER:

https://github.com/clerk/javascript/assets/825855/7ebe6706-0075-4eff-952e-c2b99f940a6e

https://linear.app/clerk/issue/SDKI-57/remove-data-invalid-styling-from-fields

Checklist

[ ] npm test runs as expected.
[ ] npm run build runs as expected.
[ ] (If applicable) JSDoc comments have been added or updated for any package exports
[ ] (If applicable) Documentation has been updated

Type of change

[x] 🐛 Bug fix
[ ] 🌟 New feature
[ ] 🔨 Breaking change
[x] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: bae2d368daf51ccd49f287540ee280f2c06326b1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR