refactor(ui): Use cx for consistent className concatenation - Githubissues

clerk / javascript

Official Javascript repository for Clerk authentication

https://clerk.com

MIT License

958 stars 212 forks source link

refactor(ui): Use cx for consistent className concatenation #3590

Closed joe-bell closed 3 weeks ago

joe-bell commented 3 weeks ago

Description

Nitpick: currently we use the default cn import (which doesn't autocomplete in some IDEs) along with clsx directly

cva exports clsx as cx; so let's use that instead!

Checklist

[x] npm test runs as expected.
[x] npm run build runs as expected.
[ ] (If applicable) JSDoc comments have been added or updated for any package exports
[ ] (If applicable) Documentation has been updated

Type of change

[ ] 🐛 Bug fix
[ ] 🌟 New feature
[ ] 🔨 Breaking change
[x] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

changeset-bot[bot] commented 3 weeks ago

🦋 Changeset detected

Latest commit: 3b031e39268d7eb3f5814998b2135b22794fce08

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR