clerk / javascript

Official Javascript repository for Clerk authentication
https://clerk.com
MIT License
958 stars 212 forks source link

feat(ui): Implement `<SignUp />` localizations #3592

Closed alexcarpenter closed 3 weeks ago

alexcarpenter commented 3 weeks ago

Description

Pulls a lot of existing code from

but opted for a function to retrieve the localized string vs the makeLocalizable component wrapper.

DEFAULT enUS:

Screenshot 2024-06-18 at 3 57 03 PM

CUSTOM arSA:

Screenshot 2024-06-18 at 3 56 17 PM

https://linear.app/clerk/issue/SDKI-67/implement-signup-localization

Will follow up with error translations based on this thread https://clerkinc.slack.com/archives/C05ST2R2HM3/p1718741779381069

Checklist

Type of change

changeset-bot[bot] commented 3 weeks ago

🦋 Changeset detected

Latest commit: a0b21126e3f350437d3bd4b1f86485d9617f6781

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

joe-bell commented 3 weeks ago

Really solid work Alex, thank you! I'll go ahead and merge to prevent any conflict pain

joe-bell commented 3 weeks ago

Created two follow-up tickets in Linear; I'll ping you internally