clerk / javascript

Official Javascript repository for Clerk authentication
https://clerk.com
MIT License
955 stars 210 forks source link

feat(chrome-extension): Poll for new active sessions #3616

Closed tmilewski closed 1 week ago

tmilewski commented 2 weeks ago

Description

Polls for active session changes allowing for synchronizing newly authenticated users after the extension has been opened.

Fixes SDK-1843

Checklist

Type of change

changeset-bot[bot] commented 2 weeks ago

🦋 Changeset detected

Latest commit: 88bc372f7fe2d14bfb7f0f819effe8ca319ecca8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ----------------------- | ----- | | @clerk/chrome-extension | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

tmilewski commented 1 week ago

LGTM

  • I wonder if we have checked that the opposite flow works. User logins to chrome extension and session is synced to website.

It's not possible in this fashion. We could, in theory, set the cookies to the permissioned domains from the extension.