feat(nextjs): Read dynamic keys from `clerkClient` within middleware runtime - Githubissues

clerk / javascript

Official Javascript repository for Clerk authentication

https://clerk.com

MIT License

955 stars 210 forks source link

feat(nextjs): Read dynamic keys from `clerkClient` within middleware runtime #3617

Closed LauraBeatris closed 1 week ago

LauraBeatris commented 2 weeks ago

Description

Resolves SDK-1253, SDK-1811, SDK-1770

PR on top of https://github.com/clerk/javascript/pull/3525 to facilitate review on clerkClient changes.

Refactoring clerkClient to be called as a function, instead of singleton, in order to read request data. It reads based on the following:

If clerkClient gets accessed on middleware runtime, then use ALS store to access dynamic keys data
If clerkClient gets accessed on application server, then use NextRequest to access dynamic keys data

Checklist

[X] npm test runs as expected.
[X] npm run build runs as expected.
[ ] (If applicable) JSDoc comments have been added or updated for any package exports
[ ] (If applicable) Documentation has been updated

Type of change

[ ] 🐛 Bug fix
[X] 🌟 New feature
[ ] 🔨 Breaking change
[ ] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

changeset-bot[bot] commented 2 weeks ago

⚠️ No Changeset found

Latest commit: 068938cd47877f30000da7164801c80ec8ac3365

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR