fix(remix): Fix issues caused by modifying duplex on Request

octoper commented 4 days ago

Description

This PR fixes an issue that was introduced by https://github.com/clerk/javascript/pull/3495, where the duplex property was already defined and couldn't not be modified.

Checklist

[ ] npm test runs as expected.
[ ] npm run build runs as expected.
[ ] (If applicable) JSDoc comments have been added or updated for any package exports
[ ] (If applicable) Documentation has been updated

Type of change

[ ] 🐛 Bug fix
[ ] 🌟 New feature
[ ] 🔨 Breaking change
[ ] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

changeset-bot[bot] commented 4 days ago

🦋 Changeset detected

Latest commit: c9e1f36a8d83c59b868afa14c3873eb6011e20a2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | ------------ | ----- | | @clerk/remix | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

octoper commented 4 days ago

@dimkl No easy way to add tests for it as we don't have the infra to support it yet, we will need to check in every runtime and provider (Vercel, Cloudflare etc). I have done manual tests in most of them

clerk / javascript