feat: add redirectUrl to `inviteMember` on OrganizationResource

clerk / javascript

Official Javascript repository for Clerk authentication

https://clerk.com

MIT License

955 stars 210 forks source link

feat: add redirectUrl to `inviteMember` on OrganizationResource #3657

Closed danielgek closed 2 days ago

danielgek commented 3 days ago

Description

Checklist

[x] npm test runs as expected.
[x] npm run build runs as expected.
[ ] (If applicable) JSDoc comments have been added or updated for any package exports
[ ] (If applicable) Documentation has been updated

Type of change

[ ] 🐛 Bug fix
[x] 🌟 New feature
[ ] 🔨 Breaking change
[ ] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

changeset-bot[bot] commented 3 days ago

⚠️ No Changeset found

Latest commit: 0e1a69f6efd2f7c61adb59d3734c922e9e9d2859

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

panteliselef commented 2 days ago

Hey @danielgek seems like this new addition is not something that our Frontend API supports, are you experiencing something different ? Have you verified that this works in an application that uses clerk-js ?

danielgek commented 2 days ago

Hey @panteliselef i got confused yesterday i was looking at this documentation: https://clerk.com/docs/reference/backend-api/tag/Organization-Invitations and i didnt even realize that there is a frontend and backend api. So to implement this i would need to basically add a backend api on my side and use you backend api ? no chance of this being added to frontend api ?

panteliselef commented 2 days ago

No worries, the implementation of the BackendAPI exists in this monorepo under packages/backend, and redirectUrl is already supported there.

I believe this is a fair request and I've forwarded it to the team. For now using Backend API would be the only way, just be aware of the rate limits that are subject to requests towards the Backend API.

danielgek commented 2 days ago

Thanks for the info @panteliselef shall I close this then ?

panteliselef commented 2 days ago

Closing this for the reasons outlined above.