clerk / javascript

Official Javascript repository for Clerk authentication
https://clerk.com
MIT License
1.12k stars 246 forks source link

fix(clerk-expo): Ensure user-agent is set correctly for iOS requests #4134

Closed wobsoriano closed 1 month ago

wobsoriano commented 1 month ago

Description

WIP, please do not merge. Not sure yet why the lockfile is that big and we might have a better way of retrieving the user-agent in iOS devices.

This PR fixes an issue where isMobile value of a SessionActivity is always false on iOS devices. The backend is likely using a library to determine device type via user-agent string. It expects a "Mobile" word to indicate a mobile device.

Resolves ECO-189

Checklist

Type of change

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: abafdbf698b2ddb058a0c9622a3ba919e1b13c1d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR