clerk / javascript

Official Javascript repository for Clerk authentication
https://clerk.com
MIT License
1.12k stars 246 forks source link

refactor(ui): Update `<Alert />` component descriptors #4164

Closed alexcarpenter closed 1 month ago

alexcarpenter commented 1 month ago

Description

Main goal is reducing the amount of dom elements, to reduce the amount of descriptors needed. No need for wrapping icon element. Visually should be no different.

BEFORE AFTER
Screenshot 2024-09-13 at 1 35 43 PM Screenshot 2024-09-13 at 1 35 15 PM

Checklist

Type of change

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 51b97656fb332c9e95eaedd9a1eefc0fca8ee6b6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR