fix(repo): Use patched yalc with support for catalog:

clerk / javascript

Official JavaScript repository for Clerk authentication

https://clerk.com

MIT License

1.17k stars 265 forks source link

fix(repo): Use patched yalc with support for catalog: #4619

Closed jacekradko closed 7 hours ago

jacekradko commented 1 day ago

Description

Current version of yalc does not support the catalog: protocol. Switching to use a patched version of yalc in the monorepo which supports this new functionality.

Checklist

[ ] pnpm test runs as expected.
[ ] pnpm build runs as expected.
[ ] (If applicable) JSDoc comments have been added or updated for any package exports
[ ] (If applicable) Documentation has been updated

Type of change

[ ] 🐛 Bug fix
[ ] 🌟 New feature
[ ] 🔨 Breaking change
[ ] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

vercel[bot] commented 1 day ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
clerk-js-sandbox	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 21, 2024 1:53am

LekoArts commented 1 day ago

To play devil's advocate here: If we want to dogfood and use https://github.com/clerk/javascript/tree/main/packages/dev-cli more we could also just remove yalc altogether

jacekradko commented 1 day ago

To play devil's advocate here: If we want to dogfood and use main/packages/dev-cli more we could also just remove yalc altogether

@LekoArts I am definitely on board with moving away from yalc. We can put that on our backlog.

I am just trying to address the immediate issue with yalc now that doesn't work properly