clessn / hublotr

Package R d'accès à clHub
Other
3 stars 0 forks source link

404 error in check_version() after installing `readr` #32

Closed judith-bourque closed 1 year ago

judith-bourque commented 1 year ago

Also, I get a 404 after installing readr, but I'm new here, so problem could be a mistake on my part. Please ask if you need anything!

image

Originally posted by @huguesmp in https://github.com/clessn/hublotr/issues/31#issuecomment-1405857469

judith-bourque commented 1 year ago

I've created a separate issue as it can be resolved separately from #31 😊

judith-bourque commented 1 year ago

When I run hublot::check_version(), I get the same error message.

judith-bourque commented 1 year ago

Proposed solution

Run each line in check_version() to see where the error comes from.

https://github.com/clessn/hublotr/blob/a21e7df12d63637f5c309e630d5ece92bd400dfd/R/util.R#L381-L405

judith-bourque commented 1 year ago

In check_version, the first warning appears from this code: https://github.com/clessn/hublotr/blob/a21e7df12d63637f5c309e630d5ece92bd400dfd/R/util.R#L385-L392

Warning message:

Warning message:
In value[[3L]](cond) : could not check for updates

If I change the repo name from hublot to hublotr in the following line, I don't get an error message: https://github.com/clessn/hublotr/blob/a21e7df12d63637f5c309e630d5ece92bd400dfd/R/util.R#L387

judith-bourque commented 1 year ago

The second error message comes from https://github.com/clessn/hublotr/blob/a21e7df12d63637f5c309e630d5ece92bd400dfd/R/util.R#L394 Error message:

Error in open.connection(5L, "rb") : HTTP error 404.

When I switch the repo name from hublot to hublotr, there is no error message.

judith-bourque commented 1 year ago

Proposed solution

Correct the repo name from hublot to hublotr in line 394 and 387.