search

cletusc / Userscript--Twitch-Chat-Emotes

Adds a button to Twitch that allows you to "click-to-insert" an emote.
http://cletusc.github.io/Userscript--Twitch-Chat-Emotes/
MIT License
36 stars 20 forks source link

Emote menu is borked, thanks to Twitch #101

Closed thinkpad4 closed 7 years ago

thinkpad4 commented 7 years ago

Use the user-emotes service in all places since tmiSession's emote parser has been removed. there is no longer a function in the session controller called getEmotes

Nareese commented 7 years ago

FYI the specific issue is session.getEmotes() is not a function at https://github.com/cletusc/Userscript--Twitch-Chat-Emotes/blob/master/src/modules/twitch-api.js#L93

cletusc commented 7 years ago

Got any docs on the "user-emotes" service? tmiSession has always been unstable.

Nareese commented 7 years ago

Possibly https://dev.twitch.tv/docs/v5/reference/chat/#get-chat-emoticons-by-set et al? I don't actually have any idea if that's the intended replacement or if there's something else. There's absolutely no discussion of the removal of this functionality on the dev tmi/chat or api boards. It may be worth posting a question there and asking.

Edit to add: Or more likely: https://dev.twitch.tv/docs/v5/reference/users/#get-user-emotes

night commented 7 years ago

@cletusc if you can setup travis to build and release this it would make it easier for me to maintain.. im not able to build this locally, some deps are screwy. i will fix this in my fork in a few

cletusc commented 7 years ago

My main concern is getting it working as-is with my current dev setup, then I'll look into setting up travis. I've got a method working for the actual retrieval of emotes (that's probably more reliable as it's an actual API call); however, there are some sorting issues popping up that I need to fix.

This won't be fixed until probably tomorrow night or some time this weekend as I don't currently have a whole lot of free time to work on this.

night commented 7 years ago

im gonna hotfix it for the moment in my fork then, if you have time i'd love to work with you on getting this better maintainable :)

cletusc commented 7 years ago

Sorry for the delay on this. This is fixed by 1415ae5a3b6dd47f70926a5213fab078b068b1e4. v2.1.5 is released.