search

cletusc / Userscript--Twitch-Chat-Emotes

Adds a button to Twitch that allows you to "click-to-insert" an emote.
http://cletusc.github.io/Userscript--Twitch-Chat-Emotes/
MIT License
36 stars 20 forks source link

support for Twitch's new site #105

Closed night closed 3 years ago

night commented 6 years ago

I scrapped together a release for supporting the new site since you're busy.. perhaps you can improve it a tad too

cletusc commented 6 years ago

Thanks for your efforts getting this going. I should hopefully have time to review this pull request this holiday weekend. If it works for you then by all means update the BTTV copy to appease the masses until I've had a chance to review this.

Martii commented 6 years ago

@night

I'd start a brief review but the affected code isn't loaded in the diff because it's "too big" according to GH.

Anywho...

This line for the SPDX code:

// @license CC BY-NC-SA 3.0; http://creativecommons.org/licenses/by-nc-sa/3.0/

needs to be:

// @license CC-BY-NC-SA-3.0; http://creativecommons.org/licenses/by-nc-sa/3.0/

in order to be considered for acceptance by the server on OUJS. Same with any other "uglified" version if applicable. See https://spdx.org/licenses/CC-BY-NC-SA-3.0.html

Plus they seem to be backwards for the dual licensing... e.g.

// @license MIT; http://opensource.org/licenses/MIT
// @license CC BY-NC-SA 3.0; http://creativecommons.org/licenses/by-nc-sa/3.0/

... should be ...

// @license CC-BY-NC-SA-3.0; http://creativecommons.org/licenses/by-nc-sa/3.0/
// @license MIT; http://opensource.org/licenses/MIT

GM's metadata policy has always been to read the last key in as primary.

https://github.com/night/Userscript--Twitch-Chat-Emotes/blob/1348602ea9d8209a44c787b7d0ec2444e5332e45/package.json#L21 ... should also, at least, be SPDX compliant for some npm standards.

If you would be so kind to fix this in here it would be highly appreciated... pending @cletusc approval of course.

Thanks for the look. :)

night commented 6 years ago

licensing issues are out of scope here.. this is not my project

Martii commented 6 years ago

No problem. At least you both know about it now. :)

cletusc commented 6 years ago

@Martii it won't be part of this pull request. Discussion for that should be over in #104 like you originally opened (but I hadn't replied yet).

This pull request will remain as @night originally opened (pull request should be pointed to fix one issue, e.g. not loading on site).

Martii commented 6 years ago

@cletusc I've created so many pull requests in the last few weeks... apologies that it was duplicated.