Closed JohnDaly closed 2 years ago
Great find & fix! I simplified the code a little -- let me know if it's still good and I'll get it merged, thanks!
Great find & fix! I simplified the code a little -- let me know if it's still good and I'll get it merged, thanks!
Looks great!
Merged and released v1.1.1, thanks for the fix!
Guys, I think this PR is causing the issue pointed in #7 since i never encountered it before with 1.1.0
Error: Failed to load plugin 'local-rules' declared in '.eslintrc.json': eslint-plugin-local-rules: Cannot find "eslint-local-rules{.js,.cjs} or eslint-local-rules/index.js (...).
Noteworthy, i don't have any require()
call into my eslint-local-rules.js
Can you please look at fixing this at your earliest convenience? Thanks in advance!
@diegocr Sorry about that!! I was literally just thinking how bad it is this thing doesn't have a single test. Reverted this changed and published as v1.1.2. I'll try again more carefully -- if you have a simplified version of your setup that errors in v1.1.1 that I can test against that would be great, thanks.
If there is a
require
statement in the 'eslint-local-rules' file, which results in aMODULE_NOT_FOUND
error, its not immediately obvious with the current error messaging.Will result in the following error:
This PR will make it so that the
Cannot find module 'bad-import-which-will-not-resolve'
error will be thrown