cleverage / eslint-config

eslint config for Clever Age projects
MIT License
2 stars 1 forks source link

prefer-destructuring AssignmentExpression #8

Open ryuran opened 5 years ago

ryuran commented 5 years ago

Currently

https://github.com/airbnb/javascript/blob/d951220399c75099838fc79577033b00530b2b90/packages/eslint-config-airbnb-base/rules/es6.js#L114-L127

    // Prefer destructuring from arrays and objects
    // https://eslint.org/docs/rules/prefer-destructuring
    'prefer-destructuring': ['error', {
      VariableDeclarator: {
        array: false,
        object: true,
      },
      AssignmentExpression: {
        array: true,
        object: true,
      },
    }, {
      enforceForRenamedProperties: false,
    }],

Proposal

    'prefer-destructuring': ['error', {
      VariableDeclarator: {
        array: false,
        object: true,
      },
      AssignmentExpression: {
        array: false,
        object: false,
      },
    }, {
      enforceForRenamedProperties: false,
    }],

https://eslint.org/docs/rules/prefer-destructuring

stephane-tessier commented 5 years ago

+1, c'est un peu violent de le forcer. Je préfère laisser le choix au codeur.