search

cleverdevil / Known-Watching

Publish a log of what you're watching (TV and Movies) to Known CMS, including a Plex webhook.
Other
12 stars 3 forks source link

Not posting a picture also results in no <h2> title #1

Open chrisaldrich opened 7 years ago

chrisaldrich commented 7 years ago

If I don't include a photo, the <h2> element which includes the title of the thing I watched doesn't display.

Compare these examples: Without photo: http://stream.boffosocko.com/2017/fresh-off-the-boat-s3-e18-time-to-get-ill With photo: http://stream.boffosocko.com/2017/fresh-off-the-boat-s3-e18-time-to-get-ill-1

I suspect that for some posts, users may quickly post what they're watching without photos, and potentially come back and add those later. (Especially in crowded movie theaters in which the show's about to start and it's rude to keep one's phone out for posting...)

Related: It would be nice if, when editing the post, the button to upload a photo was available (on the watching/edit/{hash} page) so that one could update the post with a photo after-the-fact.

cleverdevil commented 7 years ago

The first issue is resolved in this commit.

The second issue is a good point, but I've never done that before in a Known plugin. I'll have to do some research and see if there's some code elsewhere that does this that I can learn from :)

cleverdevil commented 7 years ago

Second issue is resolved in this commit. Please update and test, and if it works for you too, I'll close the issue!

chrisaldrich commented 7 years ago

I'll try them both out later this evening. You inspired me to create a Read plugin which I'll hopefully have working shortly... ;)