search

cleverhans-lab / cleverhans

An adversarial example library for constructing attacks, building defenses, and benchmarking both
MIT License
6.2k stars 1.39k forks source link

Fast Gradient Method Imports Missing Function optimize_linear #1144

Closed RylanSchaeffer closed 4 years ago

RylanSchaeffer commented 4 years ago

fast_gradient_method has an import statement for a function that no longer exists:

from cleverhans.future.torch.utils import optimize_linear

https://github.com/tensorflow/cleverhans/blob/master/cleverhans/future/torch/attacks/fast_gradient_method.py#L5

It looks like the function used to exist, but no longer:

https://github.com/tensorflow/cleverhans/blob/5c1ccc259fa836d69e9582372b0d7f97140a66ef/cleverhans/future/torch/utils.py#L69

michaelshiyu commented 4 years ago

Hi @RylanSchaeffer , I'm on the master branch and the function seems to exist.

Which branch/fork/version of the codebase are you looking at? Could you please provide more details?

Thanks.

RylanSchaeffer commented 4 years ago

I must've misclicked on something earlier. I don't know why I thought the function isn't there. My apologies.

michaelshiyu commented 4 years ago

@RylanSchaeffer no worries. It happens :)