cleverhans-lab / cleverhans

An adversarial example library for constructing attacks, building defenses, and benchmarking both
MIT License
6.2k stars 1.39k forks source link

Request to Add Pixel Attack and Threshold Attack #1146

Closed shashankkotyan closed 3 years ago

shashankkotyan commented 4 years ago

I would like to add an implementation of Few Pixel Attack (https://arxiv.org/pdf/1906.06026.pdf) which is a generalisation of One Pixel Attack (https://arxiv.org/pdf/1710.08864.pdf) and Threshold Attack (https://arxiv.org/pdf/1906.06026.pdf).

googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

shashankkotyan commented 4 years ago

@googlebot I signed it!

googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

jonasguan commented 3 years ago

Hi @shashankkotyan , thanks for the PR. Unfortunately we're undergoing some major updates and have dropped support for the current version using TF1 in favor for TF2, PyTorch and Jax, so I'll have to close this for now. However, if you would like to open a new PR for the upcoming new library version, we'd much welcome your contribution.

A few comments/questions, in case you would like to resubmit: Is the paper for the Few Pixel Attack peer-reviewed anywhere? Is it possible to implement (without too much trouble) without adding the pycma library as a dependency? Also, we'd prefer it if you can fill in the TODO comments, since it's usually best to have the developer who wrote the code add the comments to ensure correctness.