cleverhans-lab / cleverhans

An adversarial example library for constructing attacks, building defenses, and benchmarking both
MIT License
6.16k stars 1.39k forks source link

Fixed calculation of alternating sign of the jacobian augmentation update step #1165

Closed gilfidel closed 3 years ago

gilfidel commented 4 years ago

This fixes a bug in the calculation introduced in 4774fe5324742ffa915ddf676992a2f246e6ed26 that caused the sign to be negative during the first 3 jbda epochs and positive afterwards instead of alternating every 3 epochs.

googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

gilfidel commented 4 years ago

@googlebot I signed it!

googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

jonasguan commented 3 years ago

@npapernot Can you take a quick look at this?