cleverhans-lab / cleverhans

An adversarial example library for constructing attacks, building defenses, and benchmarking both
MIT License
6.2k stars 1.39k forks source link

overshoot does not work for DeepFool attack #544

Closed mehdijj closed 6 years ago

mehdijj commented 6 years ago

Changing overshoot parameter does not have any effect in DeepFool attack. I think the problem is with structural_kwargs in attack.py file. over_shoot should be changed to overshoot.

npapernot commented 6 years ago

@cihangxie could you take a look?

goodfeli commented 6 years ago

@mehdijj are you using generate or generate_np? I think that, despite the bug, it should still have an effect when you use generate. (We should still fix the bug, I just want to make sure I understand what's going on)

mehdijj commented 6 years ago

@goodfeli I'm using generate_np

cihangxie commented 6 years ago

yes, we should change the variable from over_shoot to overshoot. Sorry for this mistake

nottombrown commented 6 years ago

@cihangxie are you interested in being the owner of this issue?