search

cleverking / jaikuengine

Automatically exported from code.google.com/p/jaikuengine
0 stars 0 forks source link

JE should tell me how many characters over the 140 char limit I've gone #45

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Start typing a post
2. Make the post longer than 140 characters
3.

What is the expected output? What do you see instead?
It should tell me how many characters over the limit I've gone. Instead it
stops counting once I'm over the limit.

Please use labels and text to provide additional information.
javascript, posting

Original issue reported on code.google.com by adewale on 15 Mar 2009 at 9:37

GoogleCodeExporter commented 8 years ago 
Attached is proposed patch. Beyond what is suggested above, the counter changes 
color to red when it's over 
the limit.

The color change is governed by the p.error class in screen.css. Unfortunately, 
it needs !important to work in this 
case. Since I don't know the effect of this change, perhaps I should add a new 
class instead?

Original comment by jonasnoc...@gmail.com on 16 Mar 2009 at 2:49

Attachments:

GoogleCodeExporter commented 8 years ago 
One thing that would make these kinds of patches easier for people to think 
about is
if you deployed an instance of JE. That way other people could see the effects 
of
your patches on a variety of different operatings & browsers.

In the meantime I'll try this out on openku.appspot later today and append a
screenshot to this issue.

Original comment by adewale on 16 Mar 2009 at 3:08

GoogleCodeExporter commented 8 years ago 
I'll see if I can't get a JE instance running with the information you've 
posted over the last couple of days.

In the meantime, here's a screenshot: 
http://skitch.com/lemonad/be81t/jaikuengine-proposed-patch-for-
issue-45

Original comment by jonasnoc...@gmail.com on 16 Mar 2009 at 3:31

GoogleCodeExporter commented 8 years ago 
Slightly changed patch at http://rietku.appspot.com/1008, up for code review.

Original comment by jonasnoc...@gmail.com on 19 Mar 2009 at 11:29

GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
Issue can be closed. Commited and released in #r25.

Original comment by jonasnoc...@gmail.com on 25 Mar 2009 at 10:31

GoogleCodeExporter commented 8 years ago

Original comment by adewale on 6 Apr 2009 at 5:18