cleverness / widget-css-classes

WordPress Plugin to add CSS classes to Widgets
GNU General Public License v3.0
21 stars 11 forks source link

1.3.0 - Update for multiple predefined classes and option to use both text input and predefined classes #9

Closed JoryHogeveen closed 8 years ago

JoryHogeveen commented 8 years ago

CHANGELOG: 1.3.0

TODO:

TESTS (worked in my tests - please also check!):

cleverness commented 8 years ago

I can't find any issues so I'm going to go ahead and merge this pull request. Thank you so much for your work, it's a great feature to add.

JoryHogeveen commented 8 years ago

No problem!

JoryHogeveen commented 8 years ago

Oh before I forget. Please check the versions of the other classes. I didn't change anything there. Also, there are some changes in the translations, so the other languages will need to be updated.

EDIT: The .mo file for the Dutch translation will need to be added aswell since I couln't find a simple way to add it to Github. Shall I email this to you or will you generate one yourself?

cleverness commented 8 years ago

Email it to cindy@cleverness.org please. I won't be able to update the other translations myself since I rely on other people updating and sending them to me.

I usually don't bother changing the version on other files unless I modify them (and remember to update the version).

JoryHogeveen commented 8 years ago

I will send you the translations a.s.a.p.

About the versioning. Why not use the same file-version as the plugin-version? And then the file didn't change, don't update the version of that file. This way you can allways see in what plugin-version this file was modified. Right now the file-version doesn't say anything because you have no idea of how these versions relate to the plugin-version. What do you think?

cleverness commented 8 years ago

That's what I try to do (in general). It's something I often forget to update though when updating a file. I don't update things enough to be seem to be able to get into the habit of doing that.

Thanks for the translations.