search

cleydyr / dart-sass-maven-plugin

A Maven plugin that allows to compile SASS using Dart Sass
MIT License
15 stars 9 forks source link

[enhancement] support maven proxy settings #30

Closed gbrinkmann closed 1 year ago

gbrinkmann commented 1 year ago

It looks like the plugin is not using maven proxy settings when trying to download sass from Github. We added explicit proxy settings to a Bamboo maven task, now sass is cached.

Best regards and thanks for this plugin.

cleydyr commented 1 year ago

Hey, @gbrinkmann . Thanks for opening this issue. On version 1.0.0 the plugin doesn't accept proxy settings. I'll release this enhancement in the next release of the plugin. Unfortunately, for now, we won't be able to reuse the Maven settings as I couldn't figure out how to get the proxy configuration object from inside my plugin.

gbrinkmann commented 1 year ago

Hi @cleydyr , would maybe https://github.com/ScrapCodes/effective-pom-plugin/blob/master/src/main/java/org/apache/spark/EffectivePomMojo.java be helpful with this? [edit] sorry, looks like settings are not available here

cleydyr commented 1 year ago

Hey, @gbrinkmann . I think auto-wiring a MavenSettingsBuilder (which probably will be DefaultMavenSettingsBuilder.java) and getting a Settings instance from it will do the trick to find the proxy settings.

gbrinkmann commented 1 year ago

Hi @cleydyr , good luck, should be possible in a plugin (there's also a mvn help:effective-settings which includes proxy settings)

cleydyr commented 1 year ago

It's out on version 1.1.0. Closing this.

gbrinkmann commented 1 year ago

Hello @cleydyr and thank you, my successful testing steps are