search

cli-table / cli-table3

Pretty unicode tables for the command line
MIT License
534 stars 44 forks source link

Update projects depending on cli-table2 #17

Closed schalkneethling closed 6 years ago

schalkneethling commented 6 years ago

We should probably use @Turbo87 message he used for npm/npm#20955 as it clearly explains the situation. I am thinking that, if you are going to open a PR against one of the repos below, open a separate issue for it, and once the PR has merged, remove it from the list here? Thoughts?

This PR updates the cli-table2 dependency to cli-table3, which fixes one of the npm audit warnings :)

cli-table2 (like cli-table itself) is no longer maintained. In jamestalmage/cli-table2#43 a couple of people have offered to take over maintenance but the current maintainer did not respond so as a result the project was forked to https://github.com/cli-table/cli-table3.

Turbo87 commented 6 years ago

npm and npm-audit-report are already covered :)

Turbo87 commented 6 years ago

@schalkneethling I've converted the list above to checkboxes. I think we can check them already once a PR exists, because at that point there is not much we can do from our side. We might also want to add a link to the PR to make it easier to track progress.

schalkneethling commented 6 years ago

@Turbo87 dang it, I accidentally overwrote yours :( Thought the edited revision history might give me a way to backout mine, but that did not help. Apologies for that.

Turbo87 commented 6 years ago

Fixed it 😉

gsipos commented 6 years ago

Could you add Typescript type definitions for cli-table3? cli-table2 has type definitions under @types/cli-table2, and the same would be sufficient for cli-table3 as well, since the api is the same.

Thanks for the PR!

Turbo87 commented 6 years ago

@gsipos see #20

DanielRuf commented 6 years ago

current status: 70/351 100/351

acburdine commented 6 years ago

Ghost-CLI can be checked off the list - i'll get a release out for it sometime in the next couple of days.

imcuttle commented 6 years ago

Hi, Why not optimize the cli-table2 instead of publishing cli-table3

DanielRuf commented 6 years ago

Hi, Why not optimize the cli-table2 instead of publishing cli-table3

The maintainer did not respond so we created an actively maintained fork.

schalkneethling commented 6 years ago

@imcuttle You can see the threads that lead to this decision here[1] and here[2]

[1] https://github.com/jamestalmage/cli-table2/issues/43 [2] https://github.com/jamestalmage/cli-table2/issues/48

wagerfield commented 6 years ago

eslint-index PR merged and published to NPM v1.5.0

DanielRuf commented 6 years ago

I cleaned up the list, removed duplicates and sorted the entries. Now there are 351 instead of 411 packages in total.

schalkneethling commented 6 years ago

Thanks @DanielRuf

DanielRuf commented 6 years ago

Hm, seems GitHub has an issue with such long lists. Editing it will not update it anymore in most cases.

DanielRuf commented 6 years ago

Current list:

schalkneethling commented 6 years ago

Yeah, I have noticed that as well. We should either prune some away or, perhaps split it up into ~4 issues, so each has a smaller list?

schalkneethling commented 6 years ago

Yeah, I have noticed that as well. We should either prune some away or, perhaps split it up into ~4 issues, so each has a smaller list?

DanielRuf commented 6 years ago

Probably split it up. What do the others think?

DanielRuf commented 6 years ago

bildschirmfoto 2018-06-25 um 10 31 56

But it was posted. I guess the long list and changes to it was too much for GitHub as it does not show the changes in the changes dropdown and submitting a comment takes forever.

DanielRuf commented 6 years ago

👋

DanielRuf commented 6 years ago

New issue: https://github.com/cli-table/cli-table3/issues/28

I'll close this here to prevent duplicate work and keep things in sync.