search

cli-table / cli-table3

Pretty unicode tables for the command line
MIT License
527 stars 44 forks source link

Travis build suspended? #271

Closed speedytwenty closed 2 years ago

speedytwenty commented 2 years ago

The tests are presently failing and there is no indication of this with this in build-status badge. The last build was 6 months ago and there is no build for commits to master since then.

https://app.travis-ci.com/github/cli-table/cli-table3/branches

While I'm logged into TravisCI, it says:

Builds have been temporarily disabled for public repositories due to a negative credit balance. Please go to the [Plan page](https://app.travis-ci.com/organizations/cli-table/plan) to replenish your credit balance or alter your [Consume paid credits for OSS setting](https://app.travis-ci.com/organizations/cli-table/plan?anchor=oss-consumption).

Not sure who specifically has access to see what's going on with Travis, but it will be ideal to get this resolved so that it is apparent when the build fails (as it would presently).

DanielRuf commented 2 years ago

I would say we should move to GHA (GitHub Actions) since Travis CI had some security issues in the past and the OSS plans were trimmed down after an investor bought them.

DanielRuf commented 2 years ago

Relevant news with the new OSS (10k) credit: https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing

speedytwenty commented 2 years ago

I don't really have a preference beyond the desire of being prevented from accidentally releasing a failing build.

It looks like Travis was configured to build on Node 10, 12, and 13. I suppose it would be ideal to reestablish that by whatever means may be best—and least likely to be impeded by outages/suspensions in the future. Not too familiar with GHA and not familiar with the options available for running the builds. I can poke around but if anyone knows of a current example that'd be helpful!

Additionally, it might be worth considering a pre-commit hook that runs eslint and the tests to help ensure contributors are submitting tested code. While I don't prefer the added dependency [for dev], something like Husky would promote tested code without the dependency of a 3rd-party service.

speedytwenty commented 2 years ago

I've got an attempt of GHA in progress here: https://github.com/speedytwenty/cli-table3/pull/8

I'll get a PR in here once I've got it sufficiently working.

speedytwenty commented 2 years ago

Going to go ahead and merge this as I have a few other PRs in and more on the way.