search

cli-table / cli-table3

Pretty unicode tables for the command line
MIT License
527 stars 44 forks source link

Fix missing eslint peer dependency (affects dev only) #280

Closed speedytwenty closed 2 years ago

speedytwenty commented 2 years ago

When installing devDependencies, eslint is missing as a peer dependency:

...
➭ yarn install --frozen-lockfile
yarn install v1.22.15
[1/5] 🔍  Validating package.json...
[2/5] 🔍  Resolving packages...
[3/5] 🚚  Fetching packages...
[4/5] 🔗  Linking dependencies...
warning " > eslint-config-prettier@6.15.0" has unmet peer dependency "eslint@>=3.14.1".
warning " > eslint-plugin-prettier@3.4.0" has unmet peer dependency "eslint@>=5.0.0".
warning " > jest-runner-eslint@0.7.6" has unmet peer dependency "eslint@^4.0.0 || ^5.0.0 || ^6.0.0".
[5/5] 🔨  Building fresh packages...
✨  Done in 3.63s.

This PR adds the missing dependency (eslint@^6.0.0).

➭ rm -fr node_modules && yarn install --frozen-lockfile
yarn install v1.22.15
[1/5] 🔍  Validating package.json...
[2/5] 🔍  Resolving packages...
[3/5] 🚚  Fetching packages...
[4/5] 🔗  Linking dependencies...
[5/5] 🔨  Building fresh packages...
✨  Done in 3.08s.
speedytwenty commented 2 years ago

I suppose this might bump the versions on some of the unrelated dependencies too.