cli / gh-extension-precompile

Action for publishing binary GitHub CLI extensions
MIT License
93 stars 41 forks source link

feat: add existing_release option #26

Closed jef closed 2 years ago

jef commented 2 years ago

Description

With the current logic, if we have release titles different from "${GITHUB_REPOSITORY#*/} ${tag#v}", we create another release. I figured it would be better if the user knew they wanted to either a) create a release or b) upload to an existing release.

mislav commented 2 years ago

Hi, there is already this logic. If that doesn't work like it should, let's fix it without adding a new feature: https://github.com/cli/gh-extension-precompile/blob/f6fe3e293ed1597582d22a25dc8987e68c790df8/build_and_release.sh#L71-L73

The logic is as follows:

gabe565 commented 2 years ago

Hi, there is already this logic. If that doesn't work like it should, let's fix it without adding a new feature:

I'm using this logic in gabe565/gh-profile and can confirm it works, but I end up with a draft release that I have to delete each time the action runs.

Instead, would it make sense to check if there's an existing release before creating a draft? I could open a PR that checks the output of gh release view TAG >/dev/null.

Edit: Went ahead and created a PR for this. See #28.

jef commented 2 years ago

Superseded by https://github.com/cli/gh-extension-precompile/pull/28