Match hostnames case-insensitively

cli / go-gh

A Go module for interacting with gh and the GitHub API from the command line.

https://pkg.go.dev/github.com/cli/go-gh/v2

MIT License

322 stars 45 forks source link

Match hostnames case-insensitively #105

Closed mislav closed 1 year ago

mislav commented 1 year ago

TODO:

[ ] check if the change to FindEntry will affect alias resolution?

mislav commented 1 year ago

To avoid affecting case-sensitive alias resolution, I ideally wanted to perform case-insensitive lookups only for keys under hosts, but doing so required more changes to the implementation I was comfortable with, and the overall approach still feels brittle. Shelving this for now and making a simple workaround in the cli/cli repo.