search

cli / go-gh

A Go module for interacting with gh and the GitHub API from the command line.
https://pkg.go.dev/github.com/cli/go-gh/v2
MIT License
322 stars 45 forks source link

TokenForHost "authentication token not found" message could be more informative #112

Open mislav opened 1 year ago

mislav commented 1 year ago

Right now when gh auth token command fails for some reason, TokenForHost masks that with a generic "authentication token not found" error. I propose that the error also includes concrete reasons for the failure if they were known: for example, if gh wasn't found in the PATH.

tjgurwara99 commented 1 year ago

Not sure if this is relevant but I used to be able to get a graphql client without any issues previously but for some reason I now receive an error using the same method that was working before client, err := gh.GQLClient(nil) which returns an err along the lines of authentication token not found for host github.com. Is this to be expected or is there something that I'm missing?

mislav commented 1 year ago

We'd need more info to know what's going on there.

  1. Is your extension upgraded to the latest version of go-gh?
  2. Is gh in your PATH and up to date?
  3. Does gh auth status -h github.com work?
  4. Which OS are you on?

Thanks!

tjgurwara99 commented 1 year ago

Ok, so I was on go-gh v1.0.0 and updating to go-gh v1.2.1 fixed the issue on the extension for me - I should have done that before commenting 😅