cli / go-gh

A Go module for interacting with gh and the GitHub API from the command line.
https://pkg.go.dev/github.com/cli/go-gh/v2
MIT License
336 stars 48 forks source link

Add support to config for setting and writing blank values #143

Closed samcoe closed 1 year ago

samcoe commented 1 year ago

This PR updates the implementation of config.Set to set null yaml values instead of blank strings when passed a blank string as a value argument. We are not relying on the previous behavior anywhere and this allows us to create config keys even if they do not have any nested keys yet. We already work around this limitation in auth login and we can finally remove that code. Additionally this is necessary for the work being done in this branch which is not quiet ready for a PR yet.