search

cli / go-gh

A Go module for interacting with gh and the GitHub API from the command line.
https://pkg.go.dev/github.com/cli/go-gh/v2
MIT License
322 stars 45 forks source link

Attempt to use user configured dirs for caching #153

Closed williammartin closed 3 months ago

williammartin commented 3 months ago

Description

This change supports XDG_CACHE_DIR from the xdg spec.

A minor concern I have about moving this out of /tmp is that we might slowly fill up the disk. In practice I'm not sure that this is a big issue.

williammartin commented 3 months ago

Not going to be a problem with this review, but cli/cli has some hardcoded references to the legacy cache location

Excellent call out. Let's make sure we resolve that when we bump!