search

cli / go-gh

A Go module for interacting with gh and the GitHub API from the command line.
https://pkg.go.dev/github.com/cli/go-gh/v2
MIT License
322 stars 45 forks source link

resolveOptions not updating ClientOptions #17

Closed chelnak closed 2 years ago

chelnak commented 2 years ago

I noticed this when running some tests with the new version.

resolveOptions is not updating the pointer reference. So any changes made locally in the method are not reflected in the caller.

For example: gh.HTTPClient(nil) causes a nil value for ClientOptions to be passed to the underlying NewHTTPClient.