search

cli / go-gh

A Go module for interacting with gh and the GitHub API from the command line.
https://pkg.go.dev/github.com/cli/go-gh/v2
MIT License
322 stars 45 forks source link

Cleanup httpmock #29

Closed samcoe closed 2 years ago

samcoe commented 2 years ago

This PR gets the package formerly known as httpmock into a state that it can be made public and moved out of the internal folder.

Some major changes:

I left comments for open questions inline.

cc https://github.com/cli/go-gh/issues/28

samcoe commented 2 years ago

Closing as we decided against exporting httpmock in favor of migrating to gock in https://github.com/cli/go-gh/pull/31.