cli / go-gh

A Go module for interacting with gh and the GitHub API from the command line.
https://pkg.go.dev/github.com/cli/go-gh/v2
MIT License
322 stars 45 forks source link

Migrate from httpmock to gock #31

Closed samcoe closed 2 years ago

samcoe commented 2 years ago

This PR migrates our tests from using our homemade httpmock package with the third-party gock package. gock provides all the functionality that httpmock does and more. It also has a nice declarative DSL that is easier to understand, in my opinion. This is an alternative to https://github.com/cli/go-gh/pull/29.

cc https://github.com/cli/go-gh/issues/28