cli / go-gh

A Go module for interacting with gh and the GitHub API from the command line.
https://pkg.go.dev/github.com/cli/go-gh/v2
MIT License
322 stars 45 forks source link

Use Go 1.18 for linting #63

Closed mislav closed 1 year ago

mislav commented 1 year ago

What do you think about completely moving to 1.18

Agreed! Note that moving to 1.18 would allow us to unknowingly introduce some Go 1.18-only changes, which would be backwards-incompatible for anyone who is currently building their gh extension with 1.16. If we were post-1.0 already, we would have to be careful with such a change (and possibly bump the major version number), but since we're still in beta, I think we could upgrade the minimum required Go version without heavy repercussions.