cli / go-gh

A Go module for interacting with gh and the GitHub API from the command line.
https://pkg.go.dev/github.com/cli/go-gh/v2
MIT License
322 stars 45 forks source link

Disable govulncheck due to false positive #83

Closed mislav closed 1 year ago

mislav commented 1 year ago

govulcheck detected a case where --jq user input directly constructs a regexp in gojq code, which govulncheck considers a failure since it can lead to denial-of-service attacks. This risk doesn't not affect us, however, since we're building CLI apps and not hosted apps. As a user, you can crash your own gh process using your own malicious input as much as you'd like.

govulncheck presently does not have a way of silencing or allow-listing specific violations, so this disables govulncheck completely.

Ref. https://github.com/cli/go-gh/actions/runs/3243823451/jobs/5319105048 Reverts https://github.com/cli/go-gh/pull/71