cliaz / Titan-Panel-Classic-Reagent-Tracker

A continuation of the WoW Titan Panel Reagent Tracker addon by L'ombra.
0 stars 4 forks source link

Addon doesn't load in Wrath #25

Open perringaiden opened 8 months ago

perringaiden commented 8 months ago

With the recent updates, Wrath doesn't appear to load the addon. All 4 errors occur on every startup.

Error 1

1x ...sicReagentTracker_TBC/TitanClassicReagentTracker.lua:108: bad argument #1 to 'GetAddOnMetadata' (Invalid AddOn name TitanClassicReagentTracker. - Usage: local value = C_AddOns.GetAddOnMetadata(name, variable)) [string "=[C]"]: in function `GetAddOnMetadata' [string "@TitanClassicReagentTracker_TBC/TitanClassicReagentTracker.lua"]:108: in main chunk

Locals: (temporary) = "TitanClassicReagentTracker" (temporary) = "Version" (*temporary) = "Invalid AddOn name TitanClassicReagentTracker. - Usage: local value = C_AddOns.GetAddOnMetadata(name, variable)"

Error 2

1x ...sicReagentTracker_TBC/TitanClassicReagentTracker.lua:82: attempt to call method 'RefreshReagents' (a nil value) [string "@TitanClassicReagentTracker_TBC/TitanClassicReagentTracker.lua"]:82: in function <...sicReagentTracker_TBC/TitanClassicReagentTracker.lua:80>

Locals: self = TitanPanelReagentTrackerButton { 0 = label = FontString { } } event = "PLAYER_LOGIN" (temporary) = nil (temporary) = TitanPanelReagentTrackerButton { 0 = label = FontString { } } (*temporary) = "attempt to call method 'RefreshReagents' (a nil value)" onUpdate = defined @TitanClassicReagentTracker_TBC/TitanClassicReagentTracker.lua:57

Error 3

1x TitanClassicReagentTracker_TBC/TitanClassicReagentTracker.lua:1 (null)

Error 4

1x Interface_Wrath\FrameXML\Bindings.xml:1 TitanClassicReagentTracker_TBC/TitanClassicReagentTracker.lua:1 (null)

cliaz commented 7 months ago

Interesting. This could be due to two things:

  1. The recent changes made to support Curseforge's automated deployment
  2. The fact that Curseforge's automated deployment is now working means that a previously non-deployed version has now been delivered to you, and broke things

Question: do you update via curseforge?

Additionally, can you rename the addon folder from "TitanClassicReagentTracker_TBC" to TitanClassicReagentTracker", aka remove the trailing "_TBC" which curseforge has added

perringaiden commented 7 months ago
  1. I do use Curseforge.
  2. I tried removing and reinstalling and it recreated the _TBC folder.
  3. Renaming the folder without the _TBC, Curseforge marks it as corrupt and tries to reinstall it.
  4. However, the addon works fine with that change, before Curse gets at it.

Something is very wrong with the delivery of the addon.

Also, will Titan Panel Classic Reagent Tracker be moving to support Titan Panel 8, with Titan Panel Classic being discontinued?

cliaz commented 7 months ago

Ok, would you mind uninstalling the the version of the addon that you have, and manually installing these versions please:

Appreciate your help testing this, as I no longer have an active sub.

Re: Titan Panel 8 - thanks for the callout. I'll take a look, and if refactoring things isn't too crazy I'll continue to support this addon

perringaiden commented 7 months ago

For now, I've gone back to 3.0.5 which seems to work fine.

cliaz commented 7 months ago

First up, thanks for being a legend and testing all those versions. Appreciate it!

Secondly, from your results it appears that the things I changed to support deployment automation workflow are breaking multi-version support. From chatting to Curseforge: "We are aware that the latest solution is not ideal and are working on fixing this issue"

So, I'm going to disable automated deployment and do it manually. With that in mind, would you mind removing / uninstalling all versions of the addon that you have installed via Curseforge app, and manually installing version 3.0.6 directly from GitHub please?

If that works, I'll remove all of Curseforge's automation stuff, bump the version to v3.0.7, and push it all out manually