search

click-contrib / click-didyoumean

Enable git-like did-you-mean feature in click :sparkles:
MIT License
98 stars 9 forks source link

Drop support for Python 3.6/3.7 and extend test matrix to Python 3.11/3.12 #24

Closed sisp closed 3 months ago

sisp commented 3 months ago

I've dropped support for all EOL versions of Python (3.6 and 3.7) and extended the CI test matrix to run tests against Python 3.11 and 3.12.

sisp commented 3 months ago

Black wasn't compatible with the resolved version of Click after supporting only Python 3.8+, so I updated it to the latest available version and ran it on the code base.

timofurrer commented 3 months ago

This will also enable f-strings 🔥🔥

timofurrer commented 3 months ago

Should we just replace flake, isort etc with ruff? Wdyt?

sisp commented 3 months ago

The old Flake8 version isn't compatible with Python 3.12, so I've updated Flake8 to the latest available version. Since Flake8 requires Python 3.8.1+, I added a corresponding marker to Flake8, as this constraint originates only from a dev dependency and shouldn't leak into runtime constraints.

sisp commented 3 months ago

Should we just replace flake, isort etc with ruff? Wdyt?

Yes, perhaps in a follow-up PR? Just to avoid mixing concerns.

sisp commented 3 months ago

In fact, there's more I'd do regarding cleanup. IMO, dev dependencies should be pinned, and to support maintenance of those pins, I'd add Dependabot or Renovate to assist. See, e.g., https://github.com/fpgmaas/deptry for a quite nice setup IMO. Just an idea, it's up to you of course.